In the velocity email templates please split the ${ssSharer} variable because it holds "user shared". It makes it hard in any other language to use that. In German it needs to be something like "user has a folder shared". So, it is necessary to split the variable in to two, in order to create a correct sentence.

It would be nice too, to have an overview of the variables that are available for the velocity templates. And I talk about the Vibe/Filr specific ones like {ssSharer}.

Comments

  • I would also like to see a list of all the macros/variables available to the email templates. ${ssSharer} should never hold additional text strings, just a username value

  • You can edit the strings used by the email templates in the messages.xx file (in /opt/novell/filr/apache-tomcat/webapps/ssf/WEB-INF/messages)

  • This is really something we would expect in documentation.
    Please provide variables list and support for translations to other languages.

  • Robin, you're right that these strings can be edited.
    Anyway the problem persists for the ${ssSharer} variable since in German this string needs to be splitted into two strings. (This is what Christian indicated besides the fact that it would be nice to get a list of variables being documented somewhere.)
    So for the German locale it can be seen as a bug. Thx

  • I can't believe this hasn't been fixed or it seems the problem even understood. You don't need to be German to understand that locale specific syntax should never be embedded in a variable. Just put the name in the variable and allow us to prepare the rest of the text according to locale!

  • Today we had another look at the issue...

    We're talking about this snippet in the sharedEntryInvite.vm template:
    ==
    ..
    <div class="email-share">$esc.html(${ssSharer})</div>
    <div class="email-url"><a class="email-anchor" href="$ssVisitor.getInvitePermaLink($ssSharedEntity, $ssShareEncodedExternalUserId)">$esc.html(${ssSharedEntity.Title})</a></div>
    <div class="email-expire">$esc.html(${ssShareExpiration})</div>
    ..

    For the German locale this results in:
    ==
    <Username> freigegeben
    <Filename&Link>
    Diese Freigabe hat kein Ablaufdatum
    ==

    --> This is grammatically incorrect!

    The following would be correct.
    ==
    <Username> hat
    <Filename>
    freigegeben.
    Diese Freigabe hat kein Ablaufdatum.
    ==

    This is hard to handle with a single variable ( ${ssSharer} ).
    A fix would be to change "share.notify.sharer={0} freigegeben" to something like "share.notify.sharer={0} hat das folgende Element freigegeben:"
    (or something similar). Then the default message would be grammatically correct.

    HTH
    Cheers
    Erik